Feature - added countdown section #160
Conversation
|
Deploy preview for zothacks-site-2023-sanity ready!
|
|
Deploy preview for zothacks-site-2023 ready!
|
| } | ||
|
|
||
| .countdownMaterial { | ||
| // margin-top: 10%; |
There was a problem hiding this comment.
Chore: remove commented styling
| justify-content: center; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 400px) { |
There was a problem hiding this comment.
Chore (repeating): rather than writing out all these media queries, we can use Bootstrap's mixins to handle that for us (refer to other stylesheets using bootstrap.media-breakpoint-up)
(thanks Taesung)
|
|
||
| .outerCircle { | ||
| background-color: #ffffff; | ||
| // border-color: #1a1840; |
There was a problem hiding this comment.
Chore: remove commented styling
| span { | ||
| text-align: center; | ||
|
|
||
| @media screen and (max-width: 1000px) { |
There was a problem hiding this comment.
Chore (repeating): replace media query with bootstrap mixins
| ); | ||
| } | ||
|
|
||
| console.log(percentageCrossed); |
There was a problem hiding this comment.
Chore: Remove console logging
| position: relative; | ||
| } | ||
|
|
||
| .descriptiveText { |
There was a problem hiding this comment.
Nitpick: Because this class is used on a div, maybe change the name to description-container or something.
Also, I don't know if camel case class names is standard or having dashes in between words is standard or if there even is a standard.
| .outerCircle { | ||
| background-color: #ffffff; | ||
| // border-color: #1a1840; | ||
| border: 5px solid #1a1840; |
There was a problem hiding this comment.
Chore (repeating): The color here can be replaced with theme.$lighter-black from the theme scss file
| } | ||
|
|
||
| .innerCircle { | ||
| background-color: #bd5a5a; |
There was a problem hiding this comment.
Chore (repeating): this red is also a theme color
| } | ||
|
|
||
| .outerCircle { | ||
| background-color: #ffffff; |
There was a problem hiding this comment.
Chore (repeating): The color here can be replaced with theme.$white from the theme scss file
Added countdown section, features including:
Things which may require more work: